Skip to content

Commit

Permalink
Remove the blue color workaround for Windows (#330)
Browse files Browse the repository at this point in the history
The illegible blue color has been fixed in Windows 10 build 16257: https://blogs.msdn.microsoft.com/commandline/2017/08/02/updating-the-windows-console-colors/

The workaround causes all kinds of problems, so better to remove it than adding conditionals for older Windows versions.

Fixes #329
  • Loading branch information
sindresorhus committed Mar 12, 2019
1 parent 3ef170b commit 2ca015c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 18 deletions.
5 changes: 0 additions & 5 deletions index.js
Expand Up @@ -58,11 +58,6 @@ function Chalk(options) {
return chalkFactory(options);
}

// Use bright blue on Windows as the normal blue color is illegible
if (isSimpleWindowsTerm) {
ansiStyles.blue.open = '\u001B[94m';
}

for (const [styleName, style] of Object.entries(ansiStyles)) {
style.closeRe = new RegExp(escapeStringRegexp(style.close), 'g');

Expand Down
14 changes: 1 addition & 13 deletions test/windows.js
Expand Up @@ -29,18 +29,6 @@ test.beforeEach(() => {
test('detect a simple term if TERM isn\'t set', t => {
delete process.env.TERM;
const chalk = importFresh('..');
t.is(chalk.blue('foo'), '\u001B[94mfoo\u001B[39m');
});

test('replace blue foreground color in cmd.exe', t => {
process.env.TERM = 'dumb';
const chalk = importFresh('..');
t.is(chalk.blue('foo'), '\u001B[94mfoo\u001B[39m');
});

test('don\'t replace blue foreground color in xterm based terminals', t => {
process.env.TERM = 'xterm-256color';
const chalk = importFresh('..');
t.is(chalk.blue('foo'), '\u001B[34mfoo\u001B[39m');
});

Expand All @@ -59,5 +47,5 @@ test('apply dimmed styling on xterm compatible terminals', t => {
test('apply dimmed styling on strings of other colors', t => {
process.env.TERM = 'dumb';
const chalk = importFresh('..');
t.is(chalk.blue.dim('foo'), '\u001B[94m\u001B[2mfoo\u001B[22m\u001B[39m');
t.is(chalk.blue.dim('foo'), '\u001B[34m\u001B[2mfoo\u001B[22m\u001B[39m');
});

0 comments on commit 2ca015c

Please sign in to comment.