Strict mode in Flow definition #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindresorhus I noticed the latest release (2.4.1) to NPM was in April. Would it be possible to publish a patch-level release that includes this small patch? Having |
|
I assume this change doesn't break Flow projects that does not use the Flow strict mode? |
|
Correct! It just makes a stricter guarantee for projects that want it, without breaking anything for projects that don't require strictness. |
sindresorhus
pushed a commit
that referenced
this pull request
Jan 5, 2019
|
🙌 |
|
FYI: d3be9c6 Would be great if either of you could submit it to https://github.com/flow-typed/flow-typed |
This was referenced Oct 26, 2019
This was referenced Dec 5, 2019
This was referenced Mar 8, 2020
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the Flow definition for
chalkto use@flow strict.This makes it so that projects using
chalkcan use@flow strict(which requires all dependencies to be recursively strict).