-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tagged template literal argument type to accept unknown
instead of just string
#316
Conversation
One thing to be aware of is |
That's fine. This change will be part of the next major release anyway. |
Can you also update the Flow definition? |
Co-Authored-By: vanbujm <vanbujm@gmail.com>
@sindresorhus, I had a crack at changing the types for flow. However there are two flow tests that check for null, that fail now since a |
Can you fix the merge conflict? |
All good 👍 |
Looks like you resolved the merge conflict incorrectly. Look at the diff. |
@sindresorhus Okay, I think it is sane now. I rebased when I did the first merge and thats what made everything crazy. Ended up just going back to pre-merge, merging (correctly) this time, then force pushing my fork. There was probably more elegant git wizardry that could have been done but ¯\(ツ)/¯ |
unknown
instead of just string
Fixes #314. Changed Type to
unknown
as per @sindresorhus's request.