Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid type definition for supports-color reexport #318

Closed
langpavel opened this issue Dec 27, 2018 · 4 comments
Closed

Invalid type definition for supports-color reexport #318

langpavel opened this issue Dec 27, 2018 · 4 comments

Comments

@langpavel
Copy link

No description provided.

langpavel added a commit to langpavel/chalk that referenced this issue Dec 27, 2018
@langpavel langpavel mentioned this issue Dec 28, 2018
4 tasks
@Qix-
Copy link
Member

Qix- commented Jul 12, 2019

Can you add some context to this? I have no idea what this is about.

@tomstoneham
Copy link

Unless I'm mistaken, based on @langpavel's commit referencing this issue (b1322ea), I believe this has now been fixed in #347? I think the issue was just that the supports-color module's stdout export (which is re-exported by chalk as supportsColor) may be false in the case that there is no colour support at all, but the type definitions didn't reflect this.

@Qix-
Copy link
Member

Qix- commented Jul 24, 2019

Thanks @tomstoneham, closing unless @langpavel wants to add more context if the issue hasn't been fixed.

@langpavel
Copy link
Author

Hmm, I'm lost track of this. Reopen if appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants