Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the blue color workaround for Windows #330

Merged
merged 2 commits into from Mar 12, 2019

Conversation

sindresorhus
Copy link
Member

The illegible blue color has been fixed in Windows 10 build 16257: https://blogs.msdn.microsoft.com/commandline/2017/08/02/updating-the-windows-console-colors/

The workaround causes all kinds of problems, so better to remove it than adding conditionals for older Windows versions.

Fixes #329

The illegible blue color has been fixed in Windows 10 build 16257: https://blogs.msdn.microsoft.com/commandline/2017/08/02/updating-the-windows-console-colors/

The workaround causes all kinds of problems, so better to remove it than adding conditionals for older Windows versions.
@sindresorhus sindresorhus requested a review from Qix- March 12, 2019 12:09
@sindresorhus
Copy link
Member Author

@be5invis Do you know if #58 has been fixed in Windows 10 yet? Would have been nice to be able to remove

chalk/index.js

Lines 144 to 145 in 60959e0

// See below for fix regarding invisible grey/dim combination on Windows
builder.hasGrey = this.hasGrey || key === 'gray' || key === 'grey';
too.

@be5invis
Copy link

be5invis commented Mar 12, 2019

@sindresorhus
This is in RS5 (1809)
image
The workaround may be still needed for legacy versions (7, 8, etc.). Perhaps you can still enable it for old versions.

@sindresorhus
Copy link
Member Author

@be5invis #58 was using cmd.exe, not PowerShell.

@be5invis
Copy link

be5invis commented Mar 12, 2019

@sindresorhus
image
Node version is 10.
I think this is more clear.
I do not have older builds currently (though there server have all the historical Windows builds).
You can remove these workarounds only for version >= 17763.

@Qix-
Copy link
Member

Qix- commented Mar 12, 2019

Have they also fixed the dim issue entirely? If so then let's remove the simple windows term check entirely as @be5invis mentioned.

@sindresorhus
Copy link
Member Author

Have they also fixed the dim issue entirely? If so then let's remove the simple windows term check entirely as @be5invis mentioned.

Seems so from the comments above. I'll do that in a separate PR.

@sindresorhus sindresorhus merged commit 2ca015c into master Mar 12, 2019
@sindresorhus sindresorhus deleted the remove-blue-workaround branch March 12, 2019 13:31
sindresorhus added a commit that referenced this pull request Mar 12, 2019
See: #330

It seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as the output is not predictable.
@sindresorhus
Copy link
Member Author

You can remove these workarounds only for version >= 17763.

Not interested in supporting older builds. This workaround complicates a lot of code. Users can easily upgrade to latest Windows builds.

@sindresorhus
Copy link
Member Author

#331

sindresorhus added a commit that referenced this pull request Mar 12, 2019
See: #330

The issue seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as it makes the output unpredictable.
marado added a commit to marado/chalk that referenced this pull request Jun 30, 2019
Since chalk#330 was merged, the blue workaround for windows no longer exists, so let's remove an indication about that on the README.
billsedison pushed a commit to tc-cargo-net/chalk that referenced this pull request Jul 22, 2019
…ve dim style workaround for Windows (#331)</cargo>

See: chalk/chalk#330

The issue seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as it makes the output unpredictable.
Methuselah96 added a commit to Methuselah96/chalk that referenced this pull request Aug 29, 2021
The illegible blue color has been fixed in Windows 10 build 16257: https://blogs.msdn.microsoft.com/commandline/2017/08/02/updating-the-windows-console-colors/

The workaround causes all kinds of problems, so better to remove it than adding conditionals for older Windows versions.

Fixes chalk#329
Methuselah96 added a commit to Methuselah96/chalk that referenced this pull request Aug 29, 2021
See: chalk#330

The issue seems to have been fixed in newer Windows 10 builds. We're not interested in adding a conditional for older Windows versions as the fix severely complicates the codebase, and it also creates problems for consumers as it makes the output unpredictable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give some method to use original "blue" even under Windows
3 participants