Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript types for supportsColor which is top‑level only #342

Merged
merged 4 commits into from May 11, 2019

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Apr 25, 2019

The supportsColor property only exists on the top level:

chalk.supportsColor; // object
chalk.bold.supportsColor; // undefined

'supportsColor' in chalk; // true
'supportsColor' in chalk.bold; // false

review?(@BendingBender, @Qix-, @sindresorhus)

@ExE-Boss ExE-Boss force-pushed the fix/types/color-return branch 3 times, most recently from eec2982 to 1b168d4 Compare April 28, 2019 18:31
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
ExE-Boss and others added 2 commits May 2, 2019 16:36
Co-Authored-By: Dimitri Benin <BendingBender@users.noreply.github.com>
@sindresorhus sindresorhus changed the title fix(types): supportsColor is top‑level only Fix TypeScript types for supportsColor which is top‑level only May 11, 2019
@sindresorhus sindresorhus merged commit b3e9b91 into chalk:master May 11, 2019
@sindresorhus
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants