Add support for color=never CLI flag
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your code has support for `always`, it seems expected that `never` would work too.
I would like to use these as flags, they seem standard and have been included in `grep`
```
--colour=[when, --color=[when]]
Mark up the matching text with the expression stored in GREP_COLOR environment variable. The possible values of when can be `never', `always' or
`auto'.
```
|
Hello, arch nemesis. It seems our paths have crossed. 😈 Yeah this looks fine. I'm surprised we didn't have this already, I'll let @sindresorhus make the ultimate call but I'm 👍. |
sindresorhus
changed the title
color=never CLI flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your code has support for
always, it seems expected thatneverwould work too.I would like to use these as flags, they seem standard and have been included in
grep