Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding unit tests to project? #5

Open
jxm262 opened this issue Jul 8, 2016 · 2 comments
Open

Consider adding unit tests to project? #5

jxm262 opened this issue Jul 8, 2016 · 2 comments

Comments

@jxm262
Copy link

jxm262 commented Jul 8, 2016

Hi friend,

I think it might be worth adding some basic unit tests to help guide folks on how to setup a more "complete" application. As a newcomer to scala.js and the scalajs-react libs, one of the pain points I've been experiencing is the lack of examples of good testing. IMHO any project of decent size inevitably needs tests, so thought it would be good to add into your initial template as well.

Let me know if you think this is worth pursuing? I can submit a PR with some basic examples

@chandu0101
Copy link
Owner

Hey Justin ,

Let me know if you think this is worth pursuing? I can submit a PR with some basic examples

sure why not!, keep em coming .. , btw belated congrats on cavs win ;)

@jxm262
Copy link
Author

jxm262 commented Jul 8, 2016

Ok! Will try to get something this weekend :-)

I moved out of Cleveland recently, but yeah the Cavs are always in my heart :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants