Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changeset add is ignoring the exit code of git commit #1326

Open
disog opened this issue Mar 13, 2024 · 0 comments
Open

changeset add is ignoring the exit code of git commit #1326

disog opened this issue Mar 13, 2024 · 0 comments

Comments

@disog
Copy link

disog commented Mar 13, 2024

await git.commit(await getAddMessage(newChangeset, commitOpts), cwd);

This results in a green message saying "Empty Changeset added and committed", even though the commit might have failed. The commit might fail, for instance, if there is a pre-commit hook that spell-checks the added changeset file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant