New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an alternative indicator for selecting packages #809
Comments
I'm totally on board with the idea. Have you experimented with any changes there? Is the flow without an icon for packages that are not selected understandable by you? |
@Andarist I've proposed two alternatives:
Given my new context of the changesets and enquirer codebases, there is probably a better way to integrate this. Happy to revise! |
I encountered a similar issue trying to set up changesets for my monorepo. This was using WSL + Windows Terminal: In general, the terminal has good color/emoji support, but for some reason pressing space had no impact on the rendered checkmark, so it was impossible to tell which packages were selected. Maybe has something to do with my terminal font? Running the same command from within VSCode's built-in terminal (same shell) yields better results: Without worrying too much about the nuances of which terminal/font/platform combinations result in these problems, I'd definitely recommend adopting either of the solutions proposed by @samrose3 to ensure changesets users don't have to worry about those things either 😸 |
* Improve distinction bewtween selected and unselected prompt items Fixes #809 * Create green-meals-cough.md Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Affected Packages
pkg:@changesets/cli
Problem
When introducing Changesets to our repo, contributors had some difficulty identifying which packages were selected when creating a new changeset.
This was due to insufficient color contrast between the active and inactive checkmark ✔️ beside the package. Below is a screenshot example of a terminal color scheme with low contrast when selecting packages:
Proposed solution
An alternative selection indicator that doesn't rely on color may be a more inclusive solution. Some ideas include:
The text was updated successfully, but these errors were encountered: