Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an alternative indicator for selecting packages #809

Closed
sam-b-rose opened this issue May 20, 2022 · 3 comments · Fixed by #811
Closed

Use an alternative indicator for selecting packages #809

sam-b-rose opened this issue May 20, 2022 · 3 comments · Fixed by #811

Comments

@sam-b-rose
Copy link
Contributor

Affected Packages

pkg:@changesets/cli

Problem

When introducing Changesets to our repo, contributors had some difficulty identifying which packages were selected when creating a new changeset.

This was due to insufficient color contrast between the active and inactive checkmark ✔️ beside the package. Below is a screenshot example of a terminal color scheme with low contrast when selecting packages:

low-contrast-example

Proposed solution

An alternative selection indicator that doesn't rely on color may be a more inclusive solution. Some ideas include:

  • using a different icon/symbol to indicate a package as unselected (✖️ , ➖ , etc)
  • removing the icon when unselected (no icon indicator when inactive)
@Andarist
Copy link
Member

I'm totally on board with the idea. Have you experimented with any changes there? Is the flow without an icon for packages that are not selected understandable by you?

@sam-b-rose
Copy link
Contributor Author

sam-b-rose commented May 21, 2022

@Andarist I've proposed two alternatives:

#811

  • using a radio on/off indicator
  • using the same ✔️ for the selected (enabled) state and no indicator (" ") for unselected (disabled)

Given my new context of the changesets and enquirer codebases, there is probably a better way to integrate this. Happy to revise!

sam-b-rose added a commit to sam-b-rose/changesets that referenced this issue May 23, 2022
@ssalbdivad
Copy link

ssalbdivad commented May 30, 2022

I encountered a similar issue trying to set up changesets for my monorepo. This was using WSL + Windows Terminal:

image

In general, the terminal has good color/emoji support, but for some reason pressing space had no impact on the rendered checkmark, so it was impossible to tell which packages were selected. Maybe has something to do with my terminal font?

Running the same command from within VSCode's built-in terminal (same shell) yields better results:

image

Without worrying too much about the nuances of which terminal/font/platform combinations result in these problems, I'd definitely recommend adopting either of the solutions proposed by @samrose3 to ensure changesets users don't have to worry about those things either 😸

Andarist added a commit that referenced this issue May 30, 2022
* Improve distinction bewtween selected and unselected prompt items

Fixes #809

* Create green-meals-cough.md

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants