Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes not detected by changeset cli 2.23.1 #869

Closed
danielgangverk opened this issue Jul 12, 2022 · 10 comments
Closed

Changes not detected by changeset cli 2.23.1 #869

danielgangverk opened this issue Jul 12, 2022 · 10 comments

Comments

@danielgangverk
Copy link

Affected Packages

@changesets/cli: 2.23.1

Problem

When running changeset in the cli after having made changes in a package, no changes are detected. That is, all packages are listed as unchanged.
image

When running the same command in version 2.22.0, the changes are detected and the package is suggested in the cli.

Config

{
  "$schema": "https://unpkg.com/@changesets/config@2.0.0/schema.json",
  "changelog": ["@changesets/changelog-github", { "repo": "PRIVATE_REPO" }],
  "commit": false,
  "fixed": [],
  "linked": [],
  "access": "restricted",
  "baseBranch": "main",
  "updateInternalDependencies": "patch",
  "ignore": []
}

Proposed solution

@slinkardbrandon
Copy link

I am having this same issue, its interesting because changeset status still works, but the add command isn't detecting properly for some reason.

$ changeset status --since=main
🦋 error Some packages have been changed but no changesets were found. Run changeset add to resolve this error.
🦋 error If this change doesn't need a release, run changeset add --empty.

$ changeset add
🦋 Which packages would you like to include? …
◯ unchanged packages

@glasser
Copy link
Contributor

glasser commented Jul 13, 2022

I'm seeing this too. Note that it's specifically 2.23.1 that causes the issue (2.23.0 is fine). Sees likely that #744 is to blame? Probably this line: https://github.com/changesets/changesets/pull/744/files#r920335959

@Andarist
Copy link
Member

@BarryThePenguin
Copy link

I had the same problem, came here and found this issue, updated to 2.23.2 and it looks like that fixed the problem. Thanks! 🎉

@Andarist
Copy link
Member

This was a problem only briefly and got fixed in 2.23.2

@buquan
Copy link

buquan commented Feb 14, 2023

This was a problem only briefly and got fixed in 2.23.2

it appeared again at 2.26, need your reply, thanks

@Andarist
Copy link
Member

Please always try to share a repro case in a runnable form - either by providing a git repository to clone or a codesandbox. OSS maintainers usually can't afford the time to set up the repro, even if exact steps are given.

@buquan
Copy link

buquan commented Feb 14, 2023

Please always try to share a repro case in a runnable form - either by providing a git repository to clone or a codesandbox. OSS maintainers usually can't afford the time to set up the repro, even if exact steps are given

ok i would create demo in codesandbox recently thanks alot

@christopher-francisco
Copy link

@buquan we're seeing the same issue. Wondering if you were able to create the codesandbox?

@rossipedia
Copy link

rossipedia commented Jul 9, 2023

Hitting this also on 2.26.1, I'll see if I can provide a git repo that reproduces the issue. I believe it's related to devDependencies

• Edit •

Ok this is solved: The packages I were expecting didn't have a version field in the package.json. Adding that version field let changeset start including it in the list of packages to select.

It'd be nice if changeset offered a warning when it found a package without a version field, unless it was also listed in the ignore config option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants