Upgrade tty-table to fix deprecation warning of smartwrap transient dep #796
Conversation
🦋 Changeset detectedLatest commit: 4258b2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4258b2d:
|
|
It looks like this causes a cascade of new deps to be installed because of other out of date dependencies :( |
|
The biggest concern for this is that this (and related upgrades) bump a node version requirement - and I'm still on the fence about what to do about it. If we could maintain compat with node 12 that would be kinda sweet. Tracking this stuff through layers of packages is time-consuming though :s |
|
Ah, that's helpful context. Though every project I work on has dropped Node 12 support |
|
I think node12 will be dropped rather rapidly due to the ESM changes. Once node 18 goes LTS I think dropping 12 is fine because 12 will be 3 LTS versions behind. The trade off is being unable to fix security advisories and deprecations because the upgrades become too many. Also the build error is due to node10 not 12.
If there are matrix builds testing node12, 14, 16, 18 then we can upgrade, if the CI passes then go forward? |
when installing Changesets, get
WARN deprecated smartwrap@1.2.5
The pnpm why shows:
@changesets/cli 2.20.0
└─┬ tty-table 2.8.13
└── smartwrap 1.2.5
Looks like API is all compatible, the TS definitions in the tty-table are wrong (requires the formatter prop, which isn't required) so I left the type defs which are in the repo