From 7c1023e70fcc0d03a63fadc35c6de6dea6a285aa Mon Sep 17 00:00:00 2001 From: Jake Ginnivan Date: Sat, 29 Oct 2022 11:44:37 +0800 Subject: [PATCH 1/3] Small error message added when running changesets in a mono repo without packages --- .changeset/afraid-ways-buy.md | 5 +++++ packages/cli/src/commands/add/index.ts | 12 +++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) create mode 100644 .changeset/afraid-ways-buy.md diff --git a/.changeset/afraid-ways-buy.md b/.changeset/afraid-ways-buy.md new file mode 100644 index 000000000..f8d274800 --- /dev/null +++ b/.changeset/afraid-ways-buy.md @@ -0,0 +1,5 @@ +--- +"@changesets/cli": patch +--- + +Add error message when running changesets in a repo with pnpm/yarn workspaces configured by no packages yet diff --git a/packages/cli/src/commands/add/index.ts b/packages/cli/src/commands/add/index.ts index 9352aa483..f0cc193b0 100644 --- a/packages/cli/src/commands/add/index.ts +++ b/packages/cli/src/commands/add/index.ts @@ -20,7 +20,13 @@ export default async function add( { empty, open }: { empty?: boolean; open?: boolean }, config: Config ) { - const packages = (await getPackages(cwd)).packages.filter((pkg) => + const packages = await getPackages(cwd); + if (packages.packages.length === 0) { + throw new Error( + `No packages found in the current directory. You might have ${packages.tool} workspaces configured by no packages yet?` + ); + } + const listablePackages = packages.packages.filter((pkg) => isListablePackage(config, pkg.packageJson) ); const changesetBase = path.resolve(cwd, ".changeset"); @@ -41,8 +47,8 @@ export default async function add( .filter((pkg) => isListablePackage(config, pkg.packageJson)) .map((pkg) => pkg.packageJson.name); - newChangeset = await createChangeset(changedPackagesName, packages); - printConfirmationMessage(newChangeset, packages.length > 1); + newChangeset = await createChangeset(changedPackagesName, listablePackages); + printConfirmationMessage(newChangeset, listablePackages.length > 1); if (!newChangeset.confirmed) { newChangeset = { From ec8e92ba15ed56fd11a28cdf3ecc068a76616427 Mon Sep 17 00:00:00 2001 From: Jake Ginnivan Date: Sat, 29 Oct 2022 18:10:11 +0800 Subject: [PATCH 2/3] Update packages/cli/src/commands/add/index.ts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Mateusz Burzyński --- packages/cli/src/commands/add/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/commands/add/index.ts b/packages/cli/src/commands/add/index.ts index f0cc193b0..2112c82c3 100644 --- a/packages/cli/src/commands/add/index.ts +++ b/packages/cli/src/commands/add/index.ts @@ -23,7 +23,7 @@ export default async function add( const packages = await getPackages(cwd); if (packages.packages.length === 0) { throw new Error( - `No packages found in the current directory. You might have ${packages.tool} workspaces configured by no packages yet?` + `No packages found. You might have ${packages.tool} workspaces configured but no packages yet?` ); } const listablePackages = packages.packages.filter((pkg) => From f4fef6eeb8d7eba5ed8d1c827f305f38ecf146ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Burzy=C5=84ski?= Date: Sat, 29 Oct 2022 12:38:27 +0200 Subject: [PATCH 3/3] Update .changeset/afraid-ways-buy.md --- .changeset/afraid-ways-buy.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/afraid-ways-buy.md b/.changeset/afraid-ways-buy.md index f8d274800..c9715e462 100644 --- a/.changeset/afraid-ways-buy.md +++ b/.changeset/afraid-ways-buy.md @@ -2,4 +2,4 @@ "@changesets/cli": patch --- -Add error message when running changesets in a repo with pnpm/yarn workspaces configured by no packages yet +Add error message when running changesets in a repo with workspaces configured but no packages yet