Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler considers code in modules/packages to be standard modules #24998

Open
mppf opened this issue May 6, 2024 · 1 comment
Open

compiler considers code in modules/packages to be standard modules #24998

mppf opened this issue May 6, 2024 · 1 comment

Comments

@mppf
Copy link
Member

mppf commented May 6, 2024

Currently, the compiler applies MOD_STANDARD to code parsed from modules/packages. This means that this code isn't being checked with unstable warnings and a variety of other checks. At the same time, since modules/packages can be viewed as a place for code that could be mason packages but that is bundled with the release, it's more appropriate to label it with MOD_USER than MOD_STANDARD.

This issue serves as a place to track the TODO of resolving this issue and to discuss.

@lydia-duncan
Copy link
Member

Note that making package module code "user" may also impact standard library code as well - e.g. the Sort module is unstable, so changes to its behavior could impact places that use the Sort module (though obviously, it'd be nice if we could get our standard libraries to only rely on standard library code, either by removing references to package modules or stabilizing the module being used - if you find cases like that, feel free to ping me and I'll prioritize having someone on the stabilization team work on it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants