-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: building chapel-py-venv removes sphinx-build binary #25023
Comments
@DanilaFe - do you know why this might be? |
No idea, this is a surprise. I don't think I have any explicitly deletes / uninstalls in that code. I'll have to check it out. |
This is a wild stab in the dark, but IIRC, there is an aspect of Makefiles where, it it builds something that it considers an intermediate file, it will delete it when it's done with it. Could that be the case here? Doing a quick Google to make sure I didn't hallucinate that memory, I'm finding https://unix.stackexchange.com/questions/517190/what-causes-make-to-delete-intermediate-files |
I think this is an instance of pypa/pip#8063. As suggested by that issue, I tried just removing Specifically, the following works.
This gets some warnings, but at least works and doesn't clobber
Ideally, I think we should use proper |
I thought we moved away from proper |
Note, as of #25025, this will no longer occur. Instead, building the CLS test venv (either with So while this is still a problem that building the CLS test venv breaks chpldoc, it should not affect most users who are only building the tools themselves |
This PR builds on top of #25159. It adds support for running `make test-cls`, which runs end-to-end tests for the Chapel language server (CLS). Closes #25023. This PR does the following: * Makes sure that `test-chpl-language-server` actually gets the language server build * Adds an ordering dependency between the `chapel-py-env` and `cls-test-env` to make sure both of them don't try building a venv at the same time. * Disables `--upgrade` when building the `cls-test-venv`, which otherwise causes it to override the sphinx binary. Reviewed by @arezaii -- thanks! ## Testing - [x] `nightly -debug` on local machine with a clean checkout
I'm observing a problem where
make chplcheck-venv
removes parts of thechpl-venv
used forchpldoc
.Here is a shorter way to reproduce it:
A side issue is that
make chapel-py-venv
interleaved withmake
seems to always rebuildlibChplFrontendShared.so
.It is unclear to me if this behavior has changed recently or if I'm just running into it now.
The text was updated successfully, but these errors were encountered: