Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break YamlReadingTest into smaller parts #27

Open
charleskorn opened this issue Aug 18, 2020 · 2 comments
Open

Break YamlReadingTest into smaller parts #27

charleskorn opened this issue Aug 18, 2020 · 2 comments
Labels
frozen good first issue Good for newcomers help wanted Extra attention is needed

Comments

@charleskorn
Copy link
Owner

This file has become huge (2000+ lines 馃槺), making it difficult to navigate and slow to work with in IntelliJ.

@charleskorn charleskorn added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 18, 2020
@stale
Copy link

stale bot commented Jul 7, 2022

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. It will automatically be closed if no further activity occurs in the next seven days to enable maintainers to focus on the most important issues.
If this issue is still affecting you, please comment below within the next seven days.
Thank you for your contributions.

@stale stale bot added the stale label Jul 7, 2022
@stale stale bot removed the stale label Jul 7, 2022
@russellbanks
Copy link
Contributor

russellbanks commented May 9, 2023

Kotest doesn't support multiplatform nested tests due to limitations in Javascript, so the tests in commonTest won't actually run on all platforms unless they are refactored to not be nested.

kotest/kotest#3141 (comment):

The Javascript test runners don't support promises at the outer layer.

Therefore we cannot use coroutines anywhere but the final scope. Since kotest supports coroutines at every layer, the only way to make it work in JS land is to support flat tests only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frozen good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants