Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for list items with multi-line titles #323

Open
bashbunni opened this issue Feb 7, 2023 · 2 comments
Open

feat: add support for list items with multi-line titles #323

bashbunni opened this issue Feb 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@bashbunni
Copy link
Member

This gets asked about quite a bit. It's not very reliable when using DefaultDelegate as a workaround due to the underlying expectations for list item heights under the hood. Would be great to support this out of the box.

@bashbunni bashbunni added the enhancement New feature or request label Feb 7, 2023
@AYehia0
Copy link

AYehia0 commented Feb 8, 2023

Thank you @bashbunni :D, would you please have a look at this issue too : charmbracelet/lipgloss#167

@meowgorithm
Copy link
Member

meowgorithm commented Feb 8, 2023

One thing to note about this one is that in order to calculate the total number of pages one all the items must still be of a fixed height. Otherwise we'd only be able to determine the total number of pages by rendering and measuring every single list item. That's doesn't rule out the possibility of simply having an indeterminately paged list, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants