Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ctrl+enter] Support #927

Closed
NiloCK opened this issue Feb 14, 2024 · 5 comments
Closed

[ctrl+enter] Support #927

NiloCK opened this issue Feb 14, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@NiloCK
Copy link

NiloCK commented Feb 14, 2024

I'd like to respond to user input of ctrl+enter differently than enter. This is reasonably common now for various text inputs - eg, with enter doing a \r\n, but ctrl-enter triggering a submit or similar.

Describe the solution you'd like
key.go could provide ctrl+enter as a KeyType?

@NiloCK NiloCK added the enhancement New feature or request label Feb 14, 2024
@meowgorithm
Copy link
Member

Hi! Unfortunately, ctrl+enter isn't something historically supported by terminals. #869 will add support for this in some capacity—though keep in mind that if you want to target all terminals everywhere ctrl+enter is not available as a keybinding.

@NiloCK
Copy link
Author

NiloCK commented Feb 15, 2024

Dang. I had guessed there was a good chance that there was some external limitation here - felt like an unusual omission.

Thanks.

@meowgorithm
Copy link
Member

Yep. I'm going to close this as #869 will cover it but feel free to re-open if you feel it's still relevant.

@NiloCK
Copy link
Author

NiloCK commented Feb 15, 2024

Sounds good @meowgorithm, but a quick followup: does the same constraint apply to shift+enter?

@meowgorithm
Copy link
Member

Unfortunately, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants