Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment is not supported #117

Closed
danielhoherd opened this issue Aug 11, 2021 · 1 comment · Fixed by #317
Closed

Alignment is not supported #117

danielhoherd opened this issue Aug 11, 2021 · 1 comment · Fixed by #317
Labels
enhancement New feature or request renderer Everything related to the markdown renderer

Comments

@danielhoherd
Copy link

When rendering table columns that have alignment specified via the header separator alignment syntax, alignment is not rendered.

$ cat table-example.md
| left-aligned | center-aligned | right-aligned |
| :----------- | :------------: | ------------: |
| r1c1 | r1c2 | r1c3 |
| r2c1 | r2c2 | r2c3 |
| r3c1 | r3c2 | r3c3 |
| r4c1 | r4c2 | r4c3 |
| r5c1 | r5c2 | r5c3 |
$ glow table-example.md


    LEFT-ALIGNED │ CENTER-ALIGNED │ RIGHT-ALIGNED
  ───────────────┼────────────────┼────────────────
    r1c1         │ r1c2           │ r1c3
    r2c1         │ r2c2           │ r2c3
    r3c1         │ r3c2           │ r3c3
    r4c1         │ r4c2           │ r4c3
    r5c1         │ r5c2           │ r5c3

$ prettier table-example.md
| left-aligned | center-aligned | right-aligned |
| :----------- | :------------: | ------------: |
| r1c1         |      r1c2      |          r1c3 |
| r2c1         |      r2c2      |          r2c3 |
| r3c1         |      r3c2      |          r3c3 |
| r4c1         |      r4c2      |          r4c3 |
| r5c1         |      r5c2      |          r5c3 |
@muesli muesli transferred this issue from charmbracelet/glow Aug 12, 2021
@michaeltlombardi michaeltlombardi mentioned this issue Mar 5, 2022
Open
@muesli muesli mentioned this issue May 11, 2022
Closed
@muesli muesli added enhancement New feature or request renderer Everything related to the markdown renderer labels Oct 12, 2022
This was referenced Oct 12, 2022
Closed
Closed
@williammartin williammartin mentioned this issue Feb 26, 2024
Closed
@maaslalani maaslalani mentioned this issue Feb 26, 2024
Merged
caarlos0 added a commit that referenced this issue Jul 17, 2024
@caarlos0
test: #117

Verified

This commit was signed with the committer’s verified signature.
caarlos0 Carlos Alexandro Becker
SSH Key Fingerprint: Tc9jyTM9IRl9zFS4Q8aZgjWVpjbwK0SGkHOhCFD1OMU
Verified
Learn about vigilant mode
Loading
Loading status checks…
4830eb2
@caarlos0 caarlos0 mentioned this issue Jul 17, 2024
Merged
@caarlos0
Copy link
Member

this is fixed on master

caarlos0 added a commit that referenced this issue Jul 25, 2024
@caarlos0 @bashbunni
fix: many rendering issues (#317)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
adb0b8d 
* wip

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* wip

* wip

* wip

* fix: autolink

closes #290

* fix: escape characters

closes #106
closes #274
closes #311

* fix: table

* ci: golangci lint update

* feat: use x/golden

* test: #106

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #290

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #312

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #257

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #149

* fix: #239

* feat: use lipgloss table

closes #262

Co-authored-by: bashbunni <bunni@bashbunni.dev>

* fix: codespan is not a block

* test: #315

* test: #316

* fix: #316

* test: table

* fix: codespans, tables

* test: table

* test: #117

* test: #60

* fix: rm stylewriter

* fix: #313

* fix: margin

* fix: blocks and word wrap

* fix: build

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* chore: gitattributes

* fix: test opt

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: stable lipgloss

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: double styles

* fix: tables

* fix: tables

---------

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: bashbunni <bunni@bashbunni.dev>
bashbunni added a commit that referenced this issue Jul 31, 2024
@caarlos0 @bashbunni
fix: many rendering issues (#317)

Partially verified

This commit is signed with the committer’s verified signature.
bashbunni’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
5f5965e 
* wip

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* wip

* wip

* wip

* fix: autolink

closes #290

* fix: escape characters

closes #106
closes #274
closes #311

* fix: table

* ci: golangci lint update

* feat: use x/golden

* test: #106

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #290

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #312

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #257

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #149

* fix: #239

* feat: use lipgloss table

closes #262

Co-authored-by: bashbunni <bunni@bashbunni.dev>

* fix: codespan is not a block

* test: #315

* test: #316

* fix: #316

* test: table

* fix: codespans, tables

* test: table

* test: #117

* test: #60

* fix: rm stylewriter

* fix: #313

* fix: margin

* fix: blocks and word wrap

* fix: build

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* chore: gitattributes

* fix: test opt

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: stable lipgloss

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: double styles

* fix: tables

* fix: tables

---------

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: bashbunni <bunni@bashbunni.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request renderer Everything related to the markdown renderer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: many rendering issues charmbracelet/glamour
3 participants
@muesli @caarlos0 @danielhoherd