Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape character is rendered #311

Closed
rkochar opened this issue Aug 27, 2023 · 3 comments · Fixed by #317
Closed

Escape character is rendered #311

rkochar opened this issue Aug 27, 2023 · 3 comments · Fixed by #317
Assignees
@caarlos0
Labels
bug Something isn't working

Comments

@rkochar
Copy link

rkochar commented Aug 27, 2023

Escape characters should not be printed.

The first cell of second row should be printed as pipe | pipe where the | is escaped. The output however is pipe \| pipe

| a | b | c |
|---|---|---|
|test1|test2|test3|
|pipe \| pipe | 2 | 3 |

Setup
Please complete the following information along with version numbers, if applicable.

glow version 1.5.1 (ad21129)
@flowchartsman
Copy link

flowchartsman commented Nov 26, 2023 •
edited
Loading

This seems to be the case for most of the escapable characters supported in markdown. I ran across it when playing around with glow as a way to render godoc via gomarkdoc (which aggressively escapes all characters it can), and most of them are displayed unaltered:

image

@rkochar
Copy link
Author

rkochar commented Nov 26, 2023 •
edited
Loading

@flowchartsman Your example shows that it is a serious bug to usability. Hopefully the developers fix it soon or atleast provide a timeline. @caarlos0

@caarlos0
Copy link
Member

this bug lays in glamour, transferring

@caarlos0 caarlos0 transferred this issue from charmbracelet/glow Jul 10, 2024
caarlos0 added a commit that referenced this issue Jul 16, 2024
@caarlos0
fix: escape characters

Verified

This commit was signed with the committer’s verified signature.
caarlos0 Carlos Alexandro Becker
SSH Key Fingerprint: Tc9jyTM9IRl9zFS4Q8aZgjWVpjbwK0SGkHOhCFD1OMU
Verified
Learn about vigilant mode
Loading
Loading status checks…
fb8db4a 
closes #106
closes #274
closes #311
@caarlos0 caarlos0 mentioned this issue Jul 16, 2024
Merged
@caarlos0 caarlos0 self-assigned this Jul 16, 2024
@caarlos0 caarlos0 added the bug Something isn't working label Jul 16, 2024
bashbunni added a commit that referenced this issue Jul 31, 2024
@caarlos0 @bashbunni
fix: many rendering issues (#317)

Partially verified

This commit is signed with the committer’s verified signature.
bashbunni’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
5f5965e 
* wip

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* wip

* wip

* wip

* fix: autolink

closes #290

* fix: escape characters

closes #106
closes #274
closes #311

* fix: table

* ci: golangci lint update

* feat: use x/golden

* test: #106

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #290

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #312

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #257

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* test: #149

* fix: #239

* feat: use lipgloss table

closes #262

Co-authored-by: bashbunni <bunni@bashbunni.dev>

* fix: codespan is not a block

* test: #315

* test: #316

* fix: #316

* test: table

* fix: codespans, tables

* test: table

* test: #117

* test: #60

* fix: rm stylewriter

* fix: #313

* fix: margin

* fix: blocks and word wrap

* fix: build

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* chore: gitattributes

* fix: test opt

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: stable lipgloss

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

* fix: double styles

* fix: tables

* fix: tables

---------

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Co-authored-by: bashbunni <bunni@bashbunni.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: many rendering issues charmbracelet/glamour
3 participants
@caarlos0 @flowchartsman @rkochar