Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.1 does not build cleanly with vendored depdencies #596

Open
st3iny opened this issue Mar 17, 2024 · 1 comment
Open

v1.5.1 does not build cleanly with vendored depdencies #596

st3iny opened this issue Mar 17, 2024 · 1 comment

Comments

@st3iny
Copy link

st3iny commented Mar 17, 2024

Describe the bug
Glow does not build after vendoring dependencies.

It could be fixed by updating the lang level in go.mod and updating the lock file.

Setup
Please complete the following information along with version numbers, if applicable.

  • OS: linux 6.1.74-x86_64
  • Go: go version go1.21.7 linux/amd64

To Reproduce
Steps to reproduce the behavior:

  1. Run go mod vendor
  2. Run go build
  3. Observe the error message.
$ go mod vendor
$ go build
# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_linux.go:1018:20: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_linux.go:2297:9: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/sysvshm_unix.go:33:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)

Expected behavior
The package should build just as it does without vendored dependencies.

@st3iny st3iny changed the title Does not build with vendored depdencies Does not build cleanly with vendored depdencies Mar 17, 2024
@st3iny
Copy link
Author

st3iny commented Mar 17, 2024

I just realized that this has been fixed on master in the meantime. I tried building the latest tag v1.5.1.

A new release would fix this issue.

EDIT: The related commit is f073470.

@st3iny st3iny changed the title Does not build cleanly with vendored depdencies v1.5.1 does not build cleanly with vendored depdencies Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant