(fix): ShowOutput flag displays in realtime #405
Conversation
Fixes the `--show-output` flag not piping output. Fixes the `--show-output` flag not showing live output.
Added comments to explain output logic
hopefulTex
changed the title
| @@ -26,6 +26,7 @@ func (o Options) Run() error { | |||
| title: o.TitleStyle.ToLipgloss().Render(o.Title), | |||
| command: o.Command, | |||
| align: o.Align, | |||
| showOutput: o.ShowOutput && isTTY, | |||
There was a problem hiding this comment.
Still missing in v0.11. It prevents from using spin command :(
|
Please merge this, it's blocking my team 🙏 |
|
Sorry about the late merge, thanks for the reminder @joshmedeski! |
|
Just a heads up, this is still not working for me and a friend of mine. Should I open a new ticket to continue this work? |
|
@joshmedeski does it break, or is it as though the feature was never added back? |
|
As though the feature was never added back. I tested on main and it's working (see #453 (comment)) |
|
@joshmedeski I suggest opening a new ticket, just to keep what's been fixed and what hasn't been in order. |
|
@joshmedeski Just tested the main branch and everything appears to be working as intended. |
|
My examples were setting output to a variable then echoing it later. This is a simple example with fish: set THING (gum spin --show-output -- ping -c 4 example.com) && echo $THINGIt's working on main so hopefully on the next release the fix shows up properly, I just pulled the source code for now. |
|
Due to corp policies I am unable to pull from main or install via go, We use an internally referenced homebrew, any ETA on the next gum release that includes this fix? Thanks. |
Fixes the
--show-outputflag not piping output.Fixes the
--show-outputflag not showing live output.