From ba5ebceca802c98dbdfea7ed4967cea24b294e04 Mon Sep 17 00:00:00 2001 From: Jukka Kurkela Date: Sun, 20 Jun 2021 01:28:05 +0300 Subject: [PATCH] Bar: ignore not-grouped bars from group bar count (#9291) --- src/controllers/controller.bar.js | 4 ++ .../controller.bar/not-grouped/mixed.js | 35 ++++++++++++++++++ .../controller.bar/not-grouped/mixed.png | Bin 0 -> 11940 bytes 3 files changed, 39 insertions(+) create mode 100644 test/fixtures/controller.bar/not-grouped/mixed.js create mode 100644 test/fixtures/controller.bar/not-grouped/mixed.png diff --git a/src/controllers/controller.bar.js b/src/controllers/controller.bar.js index cf08851f361..9a568cdeb99 100644 --- a/src/controllers/controller.bar.js +++ b/src/controllers/controller.bar.js @@ -324,6 +324,10 @@ export default class BarController extends DatasetController { for (i = 0; i < ilen; ++i) { item = metasets[i]; + if (!item.controller.options.grouped) { + continue; + } + if (typeof dataIndex !== 'undefined') { const val = item.controller.getParsed(dataIndex)[ item.controller._cachedMeta.vScale.axis diff --git a/test/fixtures/controller.bar/not-grouped/mixed.js b/test/fixtures/controller.bar/not-grouped/mixed.js new file mode 100644 index 00000000000..750595312fd --- /dev/null +++ b/test/fixtures/controller.bar/not-grouped/mixed.js @@ -0,0 +1,35 @@ +module.exports = { + description: 'https://github.com/chartjs/Chart.js/issues/9281', + config: { + type: 'bar', + data: { + labels: [0, 1, 2], + datasets: [ + { + label: 'data 1', + data: [1, 2, 2], + backgroundColor: 'rgb(255,0,0,0.7)', + grouped: true + }, + { + label: 'data 2', + data: [4, 4, 1], + backgroundColor: 'rgb(0,255,0,0.7)', + grouped: true + }, + { + label: 'data 3', + data: [2, 1, 3], + backgroundColor: 'rgb(0,0,255,0.7)', + grouped: false + } + ] + }, + options: { + scales: { + x: {display: false}, + y: {display: false} + } + } + }, +}; diff --git a/test/fixtures/controller.bar/not-grouped/mixed.png b/test/fixtures/controller.bar/not-grouped/mixed.png new file mode 100644 index 0000000000000000000000000000000000000000..af2c9fda2fc3e52315e1c28509ba5a91f5c60dc3 GIT binary patch literal 11940 zcmeHNYgAKL7T!0BK}0}h22hY-RcI9rwo*_)P*Fq&u{;FjY1OKLfeJ`~0@tdb^?_EA z3IZxp1mxip3547h6)lRQLR4NsMII3nfe;8JnR8iPv-mfQ4u3i;Kh8bL*~!kAZ++S4 z+vn!!rj3r8Q)W#808OWL4z2(c^pFCR>1gU_zmx$OgOkHbceY=5L0G>*KQA7G`~Z;SjTL8*wzAvNh`ab@7cNio%Xb&1@%idU$@@9?ovS39NP54 zd8VgBmu1MgAD1*oJ}F}~l=b`~Jh@EI=3~-e_z;gpW%%;gzI;YxV&j+cCz5b3w=FFy zS86G)m00s5dG^YAhs>+3`z^b++)n563 zxIx-luRNTOq^fL-PF?{n)yT_CMW4<2k(}J@a6>c`rxW}McM1kt$ zAw4Z*xDtQzpRED;Cp6=XfX)KH+Wd8w68eS`m@nCAh>UvFBt((kt zhIO~tW>h%o5hDJU3dLTpa;q?bd!O0|3UT0h*j&t*pM8aeykEEFIW4%pK*XSdwB>Xr zG`}Fygq_jW(UC>nZCJp=2WVWLflT93-K3p^8pQQ3O}}6OT@7oA6!DDQftf4K#etvGwI9FmJ2PxmG4r@#Q-R%^RYIVFLTk($jEC=;~U6LC1i>1~uF(S*lIJheZ!vAdaFRn~g5FSAhQQ z!W6CX&=3ElZ7E=awr9k^O0a5B)^|ej?Vf&fSZBGQ2-(0gR^CM7z#k(F3M?9jG#&B18a)men%%fwA zx=0>5V|j#e(@4b3Vu#uKhB%6PZgXv5>T4^Qy2bsi1!i3P_WIO#%xW|Dw`1tLe7h~j zNDX&;!uUl4)Yd;eLBoAge&!(eUee;V9PZ_n$4`UCc*i)3Scm9X7%S}s^BqUg_~s~| zhC3Xq`f_BFz)M1BehqN!aC)>MY_y0ESPX`r+gi?meZK3vP@pMpdnf8ddKD`nR5^P{ zop6DyqL=7WuZD)?M#>~SMG`sKGN6Z7YM3ip=_qGwUd@Whuxq$w`E0mTpKe5l&b4i~ zQ46v8W~&cO){Abpg1deDGh!`)edjan#w!@yee_vIj3%%PFS$IkQ^RYkCrISAYR%JN zZIQ@>ewkTN0JX{h*CX4mG=dEyccYgHsdg*&0I3X2Z80&32Qahd0*_8&nVIPnM|% zpw>3vCC6{z28eGcw3H1BN+=t9VAqKAz{aQUwHhV}R(j`9iF(e9N-%D^TD}?8g}|>b zXh7>Kk)awyHrLz~(c$Ul_XpBYhiAFvURV(ZPc8b@W$j4d=O;+yGQxmDbV#^)B#%P+ z7#^|lmkQAy0oh#7=9cjXNR7Xn2#xnQk+ph0WlXIW>y5Kmzc&Rt?0AJMx@={@@vZ!7 zKV9&vZ)uHh@CPj>F_>t8awg_4A2x;y-SNV3c(pY$S|6?$B=b>&zV%5$7-sC#k^T+@ zH4RY%O(1yvlTGLuItWaTv3o2)P@1q}rP2`AGIb_M z&GOQW!jh~==^Ikx!G;r|@roF-Ry&NX)kx#xE7l`4fhk_=*=34A$zu#jrT_RH$q3C{wq8y%4~zx#KwoCe7GQ6QPgL$j zn_fA*W3UK+Fe>c&co0JGC<|U-0YOcj+u#(--7g=Vc3BwIOu|DiMV_SM)*TQ6XWaNo8r=?;t$cB=9A4$L8BV~ej+q3 z>md!vjIoB~uNu2tTMc*-L8tYpsdUc+03E`E0Bq`K!iGqC;GjV8qo3?#G>` zR6$lIr%=fBA84@~X;IYilt+awaU#70rKgQjmZ_*IDPsO0H?Zp!bSrn^3}3##4_|Wg zsj@2ea>igR;J(hDAHY7l-r;iqBEq+YlTpYt z?a58XkSZMCQ-~uL@_42?l=w2x!8|k$^pzvRX5IsdbpQ02L)K?_=SNmqt@G{m1GJrS4WsELM zZEF%+rlR^2C_PAKDjv>{`5}V`Nc->j`}n4qpfK%|9-b8PKxs;NH|HrG?MGSYauJq3=_m<~frN$y;?UkvUEc{=9r9n$xS_AbzbI{8A^8%NsHu*C(R4 z-7)gnsXvOG&-*ktqJlg>IuIQ+9eJ%d%GFpurWQJA7IM%b^ZiJ7ZM1rov1K>9?NBJ} z)v@nLMb zb!4#1QFj)arY+BAO+{u``uo04^t3dn%LF;$aHiQ=tZ%;~Bs7s2(M#<+&i;w7n#A|MFgJ~cEIqe))AG?^7YSZ6 zS3?s`lha)-k%dS2N=bZ;77=IADo0OuJpzw{wq!7F$0d{v@_3H1vIUmJ;UAOEE@vh@i3=Op;>^%62DJAD{sC;2l# zFcCf<5?@a$#|f>f$W@W6Qm(2jsLFz>=BhR{m0M7`h5u&7`Y|ytxsDc@T^vGMFmPJ4 L(V=ivz>oh1)Wj8d literal 0 HcmV?d00001