Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: chartjs/Chart.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.7.0
Choose a base ref
...
head repository: chartjs/Chart.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.7.1
Choose a head ref
  • 17 commits
  • 44 files changed
  • 8 contributors

Commits on Jan 1, 2022

  1. Fix using above/below filling option with discontinuous lines (#10024)

    Added a test in the boundary folder
    charlesmass2 authored Jan 1, 2022
    Copy the full SHA
    c527f47 View commit details

Commits on Jan 3, 2022

  1. Improve issue templates (#10038)

    * Make issue templates fancier
    
    * should be valid yml now
    
    * remove title field
    
    * remove reproducable sample for docs
    
    * add example back to docs, change link for plugin and add TS link for TS issues
    
    * wrong labels, forgot type: in front of it
    
    * implement feedback
    
    * gramar, missing word
    LeeLenaleee authored Jan 3, 2022
    Copy the full SHA
    51b051f View commit details

Commits on Jan 4, 2022

  1. typo Cofiguration (#10045)

    caub authored Jan 4, 2022
    Copy the full SHA
    cb1fd3f View commit details

Commits on Jan 11, 2022

  1. add typing and docs for maxTicksLimit all scales (#10057)

    * add typing and docs for maxTicksLimit time scale
    
    * change maxTicksLimit to base  instead of each scale seperatly since its done in the core.scale
    LeeLenaleee authored Jan 11, 2022
    Copy the full SHA
    4d918f5 View commit details

Commits on Jan 16, 2022

  1. Copy the full SHA
    ec67123 View commit details

Commits on Jan 27, 2022

  1. Copy the full SHA
    a7d98fb View commit details

Commits on Jan 29, 2022

  1. Change repeating alingment string to single type (#10111)

    * Change repeating alignment to single type for ease of maintenance
    * improved naming
    LeeLenaleee authored Jan 29, 2022
    Copy the full SHA
    6283c6f View commit details

Commits on Jan 31, 2022

  1. Copy the full SHA
    cc807b2 View commit details

Commits on Feb 1, 2022

  1. Sort line and bubble dataset options alphabetically (#10100)

    * Sort line and bubble dataset options alphabetically
    * moves drawActiveElementsOnTop to general section
    stockiNail authored Feb 1, 2022
    Copy the full SHA
    56661e4 View commit details

Commits on Feb 5, 2022

  1. Copy the full SHA
    49dc77e View commit details
  2. Correct type for updateHoverStyle (#10131)

    * Correct type for updateHoverStyle
    * Lint fixes
    etimberg authored Feb 5, 2022
    Copy the full SHA
    2995775 View commit details
  3. fix: allow colors as array (#10075)

    * fix: allow colors as array
    
    * Revert "fix: allow colors as array"
    
    This reverts commit 632e2ee.
    
    * fix: allow colors as array
    
    * Update types/index.esm.d.ts
    
    Co-authored-by: Jacco van den Berg <39033624+LeeLenaleee@users.noreply.github.com>
    
    Co-authored-by: Jacco van den Berg <39033624+LeeLenaleee@users.noreply.github.com>
    LovelyAndy and LeeLenaleee authored Feb 5, 2022
    Copy the full SHA
    aebbb5a View commit details

Commits on Feb 6, 2022

  1. Copy the full SHA
    c869972 View commit details
  2. Copy the full SHA
    cb81592 View commit details
  3. Sort docs sub menus alphabetically, add line and plugin sample (#10138)

    * add sample plugin for doughnut empty state
    
    * Add commented out sample, order sub cats alphabetically
    LeeLenaleee authored Feb 6, 2022
    Copy the full SHA
    7d3a1b8 View commit details

Commits on Feb 9, 2022

  1. Add missing mouse events to CoreChartOptions.events type (#10124)

    * add missing mouse events to CoreChartOptions.events type
    
    * allow all html event names in CoreChartOptions.events
    jmorel authored Feb 9, 2022
    Copy the full SHA
    b1876a4 View commit details

Commits on Feb 12, 2022

  1. Bump to 3.7.1 (#10148)

    etimberg authored Feb 12, 2022
    Copy the full SHA
    7b621d7 View commit details
Showing with 670 additions and 237 deletions.
  1. +0 −50 .github/ISSUE_TEMPLATE/BUG.md
  2. +0 −25 .github/ISSUE_TEMPLATE/DOCS.md
  3. +0 −25 .github/ISSUE_TEMPLATE/FEATURE.md
  4. +0 −27 .github/ISSUE_TEMPLATE/SUPPORT.md
  5. +84 −0 .github/ISSUE_TEMPLATE/bug.yml
  6. +5 −0 .github/ISSUE_TEMPLATE/config.yml
  7. +31 −0 .github/ISSUE_TEMPLATE/docs.yml
  8. +28 −0 .github/ISSUE_TEMPLATE/feature.yml
  9. +43 −42 docs/.vuepress/config.js
  10. +1 −0 docs/axes/cartesian/_common_ticks.md
  11. +0 −1 docs/axes/cartesian/linear.md
  12. +3 −3 docs/charts/bubble.md
  13. +1 −1 docs/charts/doughnut.md
  14. +3 −3 docs/charts/line.md
  15. +1 −1 docs/charts/polar.md
  16. +1 −1 docs/charts/radar.md
  17. +2 −2 docs/configuration/animations.md
  18. +1 −1 docs/configuration/index.md
  19. +1 −1 docs/configuration/subtitle.md
  20. +1 −1 docs/getting-started/v3-migration.md
  21. +2 −2 docs/samples/information.md
  22. +136 −0 docs/samples/line/point-styling.md
  23. +77 −0 docs/samples/plugins/doughnut-empty-state.md
  24. +1 −1 package-lock.json
  25. +1 −1 package.json
  26. +1 −1 src/helpers/helpers.config.js
  27. +1 −1 src/helpers/helpers.extras.js
  28. +23 −2 src/plugins/plugin.filler.js
  29. +4 −4 src/plugins/plugin.tooltip.js
  30. +53 −0 test/fixtures/plugin.filler/line/boundary/above-below-line-null-start.json
  31. BIN test/fixtures/plugin.filler/line/boundary/above-below-line-null-start.png
  32. +53 −0 test/fixtures/plugin.filler/line/boundary/above-below-line-null.json
  33. BIN test/fixtures/plugin.filler/line/boundary/above-below-line-null.png
  34. +1 −1 test/specs/controller.line.tests.js
  35. +1 −1 test/specs/core.animations.tests.js
  36. +2 −2 test/specs/core.controller.tests.js
  37. +1 −1 test/specs/helpers.interpolation.tests.js
  38. +1 −1 test/specs/scale.time.tests.js
  39. +1 −1 types/helpers/helpers.extras.d.ts
  40. +24 −34 types/index.esm.d.ts
  41. +32 −0 types/tests/controllers/line_span_gaps.ts
  42. +17 −0 types/tests/interaction.ts
  43. +2 −0 types/tests/register.ts
  44. +30 −0 types/tests/scales/time_string_max.ts
50 changes: 0 additions & 50 deletions .github/ISSUE_TEMPLATE/BUG.md

This file was deleted.

25 changes: 0 additions & 25 deletions .github/ISSUE_TEMPLATE/DOCS.md

This file was deleted.

25 changes: 0 additions & 25 deletions .github/ISSUE_TEMPLATE/FEATURE.md

This file was deleted.

27 changes: 0 additions & 27 deletions .github/ISSUE_TEMPLATE/SUPPORT.md

This file was deleted.

84 changes: 84 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
name: Bug Report
description: Something went awry
labels: ["type: bug"]
body:
- type: markdown
attributes:
value: |
Need help or support?
Please don't open an issue! Head to https://stackoverflow.com/questions/tagged/chart.js.
- type: markdown
attributes:
value: "Bug reports MUST be submitted with an interactive example: https://codepen.io/pen?template=BapRepQ."

- type: markdown
attributes:
value: Chart.js versions lower then 3.x are NOT supported anymore, new issues will be disregarded.

- type: textarea
attributes:
label: Expected behavior
description: Tell us what should happen.
validations:
required: true

- type: textarea
attributes:
label: Current behavior
description: Tell us what happens instead of the expected behavior.
validations:
required: true

- type: input
attributes:
label: Reproducible sample
description: |
Please provide issue reproduction.
You can use [this codepen](https://codepen.io/pen?template=BapRepQ) to make a reproducible sample.
Major framework wrappers for chart.js templates:
[vue-chart-3 sandbox (Vue)](https://codesandbox.io/s/vue-chart-3-chart-js-issue-template-bpg7k?file=/src/App.vue)
[ng2-charts sandbox (Angular)](https://codesandbox.io/s/ng2charts-chart-js-issue-template-fhezt?file=/src/app/app.component.ts)
[react-chartjs-2 sandbox (React)](https://codesandbox.io/s/react-chartjs-2-chart-js-issue-template-cg7b5?file=/src/App.tsx)
For typescript issues you can make use of [this TS Playground](https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgYQBYENZwL5wGZQQhwDkAxhrAHQBWAziQNwCwAUGwG6ZxkwAecALxwAJhDIBXEAFMAdjCoBzaTACiAG2kz5AIQCeASREAKAEQg9aTDFMBKOOjpwAEgBUAsgBlk6WVzoaWnIwLKxcUHAWVljCstIA7iiUMMa8fAA0iGxwOXAwemDSAFyk6sBxJOnZuSLoMOglCNW5ueroAEbS6nQlANqmAErSIqaZpjrqEtKjcKYAml3qEPEzpgDiUNJyqwAKElBgmqsA8lC+yqYAulWsLS219XQqPXC9Tbd3n22d6iUkAMRwCB4OAANQgMGkDBun0+DwarwAjAAmTKIgCcmQAzJkAKyZVFwLHXZp3bCXUnYGG5CBgGDACCyF7vT50MjoTTM0ktPiNbl3fk5KmCuB6PkfWFwEXYfkyiU4NjYWyMIA) to make a reproducible sample.
If filing a bug against `master`, you may reference the latest code via
https://www.chartjs.org/dist/master/chart.min.js (changing the filename to
point at the file you need as appropriate). Do not rely on these files for
production purposes as they may be removed at any time.
validations:
required: true

- type: textarea
attributes:
label: Optional extra steps/info to reproduce

- type: textarea
attributes:
label: Possible solution
description: If you have suggestions on a fix for the bug.

- type: textarea
attributes:
label: Context
description: |
How has this issue affected you? What are you trying to accomplish?
Providing context helps us come up with a solution that is most useful in the real world.
- type: input
attributes:
label: chart.js version
description: Which version of `chart.js` are you using?
placeholder: "v0.0.0"
validations:
required: true

- type: input
attributes:
label: Browser name and version

- type: input
attributes:
label: Link to your project
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
blank_issues_enabled: false
contact_links:
- name: Support, Help, and Advice
url: https://stackoverflow.com/questions/tagged/chart.js
about: Need help or support? Head to https://stackoverflow.com/questions/tagged/chart.js
31 changes: 31 additions & 0 deletions .github/ISSUE_TEMPLATE/docs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Documentation
description: Are the docs lacking or missing something?
labels: ["type: documentation"]
body:
- type: checkboxes
attributes:
label: "Documentation Is:"
options:
- label: Missing or needed?
- label: Confusing
- label: Not sure?

- type: textarea
attributes:
label: Please Explain in Detail...
validations:
required: true

- type: textarea
attributes:
label: Your Proposal for Changes
validations:
required: true

- type: input
attributes:
label: Example
description: |
Provide a link to a live example demonstrating the issue or feature to be documented:
Normal: https://codepen.io/pen?template=BapRepQ
TS: [TS Playground](https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgYQBYENZwL5wGZQQhwDkAxhrAHQBWAziQNwCwAUGwG6ZxkwAecALxwAJhDIBXEAFMAdjCoBzaTACiAG2kz5AIQCeASREAKAEQg9aTDFMBKOOjpwAEgBUAsgBlk6WVzoaWnIwLKxcUHAWVljCstIA7iiUMMa8fAA0iGxwOXAwemDSAFyk6sBxJOnZuSLoMOglCNW5ueroAEbS6nQlANqmAErSIqaZpjrqEtKjcKYAml3qEPEzpgDiUNJyqwAKElBgmqsA8lC+yqYAulWsLS219XQqPXC9Tbd3n22d6iUkAMRwCB4OAANQgMGkDBun0+DwarwAjAAmTKIgCcmQAzJkAKyZVFwLHXZp3bCXUnYGG5CBgGDACCyF7vT50MjoTTM0ktPiNbl3fk5KmCuB6PkfWFwEXYfkyiU4NjYWyMIA)
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE/feature.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Feature Request
description: Suggest an idea
labels: ["type: enhancement"]
body:
- type: markdown
attributes:
value: |
Most features should start as plugins outside of Chart.js
(https://www.chartjs.org/docs/latest/developers/plugins.html).
Please consider whether your changes are useful for all users, or if this is
specific to your usecase and a Chart.js plugin would be more appropriate.
Need help or tech support? Please don't open an issue!
Head to https://stackoverflow.com/questions/tagged/chart.js
- type: textarea
attributes:
label: Feature Proposal
description: |
What are you trying to accomplish?
Providing context helps us come up with a solution that is most useful in the real world
validations:
required: true

- type: textarea
attributes:
label: Possible Implementation
description: Not obligatory, but suggest ideas for how to implement the addition or change
Loading