Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radialLinear: fix getIndexAngle when there are no labels (left) #10020

Merged
merged 7 commits into from Dec 23, 2021

Conversation

LeeLenaleee
Copy link
Collaborator

@LeeLenaleee LeeLenaleee added this to the Version 3.7.0 milestone Dec 23, 2021
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation is fine, but this way we could save some bytes :)

src/scales/scale.radialLinear.js Outdated Show resolved Hide resolved
src/scales/scale.radialLinear.js Outdated Show resolved Hide resolved
@LeeLenaleee
Copy link
Collaborator Author

LeeLenaleee commented Dec 23, 2021

It saved more bytes as I expected, interesting

@LeeLenaleee LeeLenaleee changed the title Resolve animation if indexAngle is NaN PolarArra resolve animation if indexAngle is NaN Dec 23, 2021
@kurkle kurkle changed the title PolarArra resolve animation if indexAngle is NaN radialLinear: fix getIndexAngle when there are no labels (left) Dec 23, 2021
@kurkle kurkle merged commit d24fe14 into chartjs:master Dec 23, 2021
@LeeLenaleee LeeLenaleee deleted the bug/animate-last-polar-slice branch January 16, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last slice polar Area does not animate
2 participants