Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor filler plugin for easier maintenance #10040

Merged
merged 1 commit into from Feb 12, 2022
Merged

Refactor filler plugin for easier maintenance #10040

merged 1 commit into from Feb 12, 2022

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jan 1, 2022 •
edited

Closes #10039 (includes it)

Quite extensive refactoring of the filler plugin

image

@kurkle
Copy link
Member Author

kurkle commented Jan 1, 2022

CC: 16 fixed, 11 new => 5 fixed issues. So only the file length issue in addition to #10039

@kurkle
Copy link
Member Author

kurkle commented Jan 1, 2022

Filename Size Change
dist/chart.esm.js 73.8 kB +104 B (0%)
dist/chart.js 93.2 kB +102 B (0%)
dist/chart.min.js 66.2 kB +28 B (0%)

@kurkle kurkle added this to the Version 3.8.0 milestone Jan 2, 2022
@kurkle kurkle mentioned this pull request Jan 2, 2022
Closed
@etimberg
Copy link
Member

@kurkle is this safe to merge?

@kurkle
Copy link
Member Author

kurkle commented Feb 12, 2022

@kurkle is this safe to merge?
Yes, was waiting for 3.7.1 to be released first.

@kurkle kurkle merged commit 4b54268 into chartjs:master Feb 12, 2022
@kurkle kurkle deleted the filler-refactor branch February 12, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kurkle @etimberg @LeeLenaleee