Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort docs sub menus alphabetically, add line and plugin sample #10138

Merged
merged 2 commits into from Feb 6, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

Closes #10122

etimberg
etimberg previously approved these changes Feb 6, 2022
@@ -304,33 +305,33 @@ module.exports = {
title: 'Configuration',
children: [
'configuration/',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left this at the top since its the same as the title block so I think this looks better but its not 100% alphabetically sorted, same goes for developers section.

@LeeLenaleee LeeLenaleee changed the title Add example plugin for doughnut empty state Sort docs sub menus alphabetically, add line and plugin sample Feb 6, 2022
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks ok to me

@kurkle kurkle requested a review from etimberg February 6, 2022 19:48
@etimberg etimberg merged commit 7d3a1b8 into chartjs:master Feb 6, 2022
@LeeLenaleee LeeLenaleee deleted the docs/doughnut-sample-plugin branch February 6, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Empty State for Doughnut Chart
3 participants