Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in Animations docs page. #10184

Merged
merged 1 commit into from Feb 22, 2022
Merged

Conversation

pzelnip
Copy link
Contributor

@pzelnip pzelnip commented Feb 21, 2022

Fix broken link to animations sample.

etimberg
etimberg previously approved these changes Feb 21, 2022
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link text should be updated since it doesn't link to GitHub, something like progress bar sample.

Also instead of an hard link a soft link would be better so that later versions of the docs point to their own sample and not the the sample in the latest version.

Fix broken link to animations sample.
@etimberg etimberg merged commit 6a6693e into chartjs:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants