Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct chart initialization flow #10266

Merged
merged 2 commits into from Mar 31, 2022
Merged

Conversation

LeeLenaleee
Copy link
Collaborator

Order in which hooks were called was wrong in flow chart
https://jsfiddle.net/Leelenaleee/pLj20hu4/11/

Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the draw.io file be updated as well?

@LeeLenaleee
Copy link
Collaborator Author

No, the .drawio file only has the render pipeline flowchart in it

etimberg
etimberg previously approved these changes Mar 29, 2022
@etimberg
Copy link
Member

I'm surprised, I thought I put all of them in there.

@LeeLenaleee
Copy link
Collaborator Author

MB, you did, did not notice the tabs at the bottom.

Would have made live bit easyer since the png had the incorrect chart in its metadata 😅

Will update drawio file too

@etimberg etimberg merged commit 4c42bd0 into chartjs:master Mar 31, 2022
@LeeLenaleee LeeLenaleee deleted the docs/flowchart branch March 31, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants