Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document tooltip draw hooks and only call hooks when the tooltip draws #10276

Merged
merged 2 commits into from Apr 3, 2022

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Apr 2, 2022

Resolves #10002

Not sure if this counts as a breaking change or not for the plugin.tooltip.js changes.

@LeeLenaleee
Copy link
Collaborator

Technically it will be breaking since it can alter custom code that relied on it being fired every render cycle.

But I think it should be considered a bug fix instead of a breaking change since in its current form for most usecasses if you want to use it you can't use it.

@etimberg etimberg added this to the Version 3.8.0 milestone Apr 3, 2022
@etimberg etimberg merged commit 43889f2 into chartjs:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip before and after draw hooks not documented and weird behaviour
3 participants