Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow time scale to offset using skipped ticks #10278

Merged

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Apr 3, 2022

Resolves #10215 using a new option for time scales called offsetAfterAutoskip.

If there are better option names, we can use that too. Perhaps an offsetTicks setting with two options: 'all' and 'skipped'

@kurkle
Copy link
Member

kurkle commented Apr 3, 2022

Could be also a new value for the existing offset option. offset: true // === 'all', offset: 'skipped'.
But I'm not really a fan of that :)

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it break many fixtures if this would be default? Just wondering if the option could be avoided.
In case the option is needed, the suggested one is fine by me.

@etimberg
Copy link
Member Author

etimberg commented Apr 3, 2022

Setting this as the default breaks 2 fixtures

@etimberg
Copy link
Member Author

etimberg commented Apr 3, 2022

One of those changes is pretty big
changed fixture
though

@kurkle
Copy link
Member

kurkle commented Apr 3, 2022

That one does not have any ticks, so could maybe be worked around.. But anyway, I think its safer to have the new option.

@etimberg
Copy link
Member Author

etimberg commented Apr 3, 2022

I agree, a new option makes more sense. We can change the default at v4

@etimberg etimberg added this to the Version 3.8.0 milestone Apr 3, 2022
@etimberg etimberg merged commit a39f694 into chartjs:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar Chart offset property Does not work with time axis type
2 participants