display tooltips only at points in chart area #10289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
requested changes
Apr 16, 2022
src/core/core.interaction.js
Outdated
| @@ -97,6 +97,10 @@ function getIntersectItems(chart, position, axis, useFinalPosition) { | |||
| } | |||
|
|
|||
| const evaluationFunc = function(element, datasetIndex, index) { | |||
| const chartArea = chart.chartArea; | |||
| if (element.x < chartArea.left || chartArea.right < element.x || element.y < chartArea.top || chartArea.bottom < element.y) { | |||
There was a problem hiding this comment.
I would use the _isPointInArea helper function here.
There was a problem hiding this comment.
This seems to be the only issue here, @t-mangoe will you be able to update this PR?
There was a problem hiding this comment.
Oh, sorry. I noticed the comment, but have not yet updated it.
I will try to respond, so I hope you can wait.
(Or, I allow edits by maintainers, so it is ok that maintainers update this PR.)
etimberg
approved these changes
May 7, 2022
kurkle
approved these changes
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added code to display tooltips only at points in chart area.
This solves the issue of #10108