Enable configuration of radial scale point label border radius #10293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
commented
Apr 11, 2022
| @@ -208,9 +208,28 @@ function drawPointLabels(scale, labelCount) { | |||
| const {backdropColor} = optsAtIndex; | |||
|
|
|||
| if (!isNullOrUndef(backdropColor)) { | |||
| const borderRadius = toTRBLCorners(optsAtIndex.borderRadius); | |||
There was a problem hiding this comment.
I had a default value of 0 added for this new setting after line 606, but then the option failed to work. The proxy always showed the default value instead of what was specified. Not sure why that was the case, but leaving no default also worked
kurkle
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configurable
borderRadiusto radial scale point labels.