Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for each dataset to be individually typed without a main type #10387

Merged
merged 3 commits into from May 31, 2022
Merged

Allow for each dataset to be individually typed without a main type #10387

merged 3 commits into from May 31, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

resolves: #10382

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label May 30, 2022
@LeeLenaleee LeeLenaleee added this to the Version 3.8.1 milestone May 30, 2022
kurkle
kurkle reviewed May 31, 2022
View reviewed changes
types/tests/chart_types.ts Outdated Show resolved Hide resolved
@etimberg etimberg merged commit 2486fe2 into chartjs:master May 31, 2022
@LeeLenaleee LeeLenaleee deleted the types/individually-typed-datasets branch May 31, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 3.8.1
Development

Successfully merging this pull request may close these issues.

Mixed chart example in documentaion has a configuration that doesnt match the ChartConfiguration Type
3 participants
@LeeLenaleee @etimberg @kurkle