Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify api docs #10392

Merged
merged 1 commit into from Jun 1, 2022
Merged

Clarify api docs #10392

merged 1 commit into from Jun 1, 2022

Conversation

LeeLenaleee
Copy link
Collaborator

Comming from #10329 (reply in thread) and #10390

Add some more methods to the API page of the docs for clarification and add sample of how to pass the update mode to updating charts page

@etimberg etimberg merged commit 7b01d33 into chartjs:master Jun 1, 2022
@stockiNail
Copy link
Contributor

@LeeLenaleee if I may, let me jump in this topic. I see that draw method is not documented. I'm wondering why.

And also isDatasetVisible(index). Maybe there is a good reason and apologize if I'm wrong.

@LeeLenaleee
Copy link
Collaborator Author

No I am just verry tired and was planning to get at least the getSortedVisibleDatasetMetas documented and on the update page clarify the mode with a sample and while I was doing that I added some more that I quickly noticed that also missed and could be added

@stockiNail
Copy link
Contributor

Thank you @LeeLenaleee !! I have this item in my long TODO list and as soon as I have time, maybe I can submit a PR adding those 2 methods (even if my English is not good enough to write a good documentation ;) ).

@LeeLenaleee LeeLenaleee deleted the docs/add-api-methods branch June 1, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants