Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve plugin defaults for local plugins #10484

Merged
merged 1 commit into from Jul 24, 2022
Merged

Resolve plugin defaults for local plugins #10484

merged 1 commit into from Jul 24, 2022

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jul 18, 2022

Fix #10482

@stockiNail
Copy link
Contributor

@kurkle apologize if I jump in this topic. Could it make sense to add to the documentation (in type definition as well) that a plugin could have a defaults property? As far as I have seen, this is not mentioned anywhere.

@LeeLenaleee LeeLenaleee added this to the Version 3.8.1 milestone Jul 19, 2022
@LeeLenaleee LeeLenaleee mentioned this pull request Jul 19, 2022
Merged
@etimberg
Copy link
Member

@kurkle are we good to merge this? It looks like doing so would close off 3.8.1

@kurkle kurkle merged commit 9ba4480 into chartjs:master Jul 24, 2022
@kurkle kurkle deleted the local-plugin-defaults branch July 24, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.8.1
Development

Successfully merging this pull request may close these issues.

Plugin defaults do not apply when plugin is not registered
4 participants
@kurkle @stockiNail @etimberg @LeeLenaleee