fix: stacked bar chart minBarLength causes overlapping #10766
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new private field
_visualValues
inmeta.parsed._stacks[axis]
, which stores the data coordinates of the bar rendered after applyingminBarLength
, and is then used inapplyStack()
instead of the actual value.Added two fixture unit tests for the expected behavior of both vertical and horizontal stacked bar chart, using linear axis.
Please note that this PR did not handle logarithmic axis properly. Would appreciate if anyone can help on that.
Thank you @etimberg and @kurkle for all the help on Slack! Feedback is welcome!
Closes #10664.