Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: colors for mixed charts #10870

Merged
merged 1 commit into from Nov 18, 2022
Merged

feat: colors for mixed charts #10870

merged 1 commit into from Nov 18, 2022

Conversation

dangreen
Copy link
Collaborator

No description provided.

@dangreen dangreen marked this pull request as ready for review November 13, 2022 21:08
@LeeLenaleee
Copy link
Collaborator

LeeLenaleee commented Nov 13, 2022

It seems to already work fine, or am I missing something image

@dangreen
Copy link
Collaborator Author

@LeeLenaleee It works fine only for certain chart types

master:

Снимок экрана 2022-11-14 в 13 17 26

this branch:

Снимок экрана 2022-11-14 в 13 33 38

@@ -0,0 +1,45 @@
module.exports = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this test also pass the old one case, see my screenshot from yesterday?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeeLenaleee fixed

@dangreen
Copy link
Collaborator Author

@LeeLenaleee @etimberg @kurkle review please 🙏

kurkle
kurkle previously approved these changes Nov 17, 2022
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

LeeLenaleee
LeeLenaleee previously approved these changes Nov 17, 2022
@etimberg
Copy link
Member

This needs a rebase now @dangreen

@dangreen dangreen dismissed stale reviews from LeeLenaleee and kurkle via 1fa932a November 17, 2022 14:43
@etimberg etimberg merged commit 22f0dfe into chartjs:master Nov 18, 2022
@dangreen dangreen deleted the feat-colors-plugin-mixed-charts branch November 21, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants