add getLabelItems public method #10966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… public-get-labels
|
@LeeLenaleee @etimberg @kurkle review please 🙏 |
LeeLenaleee
requested changes
Dec 14, 2022
There was a problem hiding this comment.
Should also update the docs
https://www.chartjs.org/docs/master/developers/api.html
|
@LeeLenaleee, I'm out of the context of the changes. I'm just fixing CI here. Could you help me with this? |
kurkle
approved these changes
Dec 15, 2022
That doc is for the Chart class, this change is in scale. Typedoc will generate an entry for this. |
etimberg
approved these changes
Dec 16, 2022
Yes mb |
LeeLenaleee
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #10837