Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Slack link #10976

Merged
merged 1 commit into from Dec 14, 2022
Merged

docs: Update Slack link #10976

merged 1 commit into from Dec 14, 2022

Conversation

igorlukanin
Copy link
Member

Currently, a link to join Chart.js Slack doesn't work because a slackin deployment on Heroku doesn't work as well.

Fortunately, now Slack has an option to share an invitation link.

I've updated all places I've found with such a link.
Screen Shot 2022-12-14 at 19 56 57

@igorlukanin
Copy link
Member Author

I think we'll also need to make a dummy 4.0.2 release to update the latest version of docs with new links, right?

@LeeLenaleee
Copy link
Collaborator

We can just release a 4.1.0 instead would be better as a dummy release in my eyes

README.md Show resolved Hide resolved
@igorlukanin
Copy link
Member Author

@LeeLenaleee I agree that a regular 4.1 release would be better but it doesn't seem to be ready yet, 7 issues still open as of this moment. I'd like to do this launch tomorrow—and it would be better for Slack links to work, that's why I suggested a dummy release. WDYT?

@LeeLenaleee
Copy link
Collaborator

Can take a look what we can put through tonight do a version bump and move the rest to V4.1.1 or V4.2.0 because that would be easier to do i think as a V4.1.2 release since there are already enhancements in master

@igorlukanin
Copy link
Member Author

That sounds great @LeeLenaleee, many thanks!

@LeeLenaleee LeeLenaleee merged commit acfb981 into chartjs:master Dec 14, 2022
@igorlukanin igorlukanin deleted the fix-slack branch December 15, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants