Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix Plugin interface #11016

Merged
merged 1 commit into from Dec 22, 2022
Merged

fix: fix Plugin interface #11016

merged 1 commit into from Dec 22, 2022

Conversation

dangreen
Copy link
Collaborator

Fixes #11014

@dangreen
Copy link
Collaborator Author

Context: https://github.com/microsoft/TypeScript/wiki/Breaking-Changes/83af27fca396d172b4d895d480b10c3bacf89112#-k-string-unknown--is-no-longer-a-wildcard-assignment-target

@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Dec 22, 2022
@LeeLenaleee LeeLenaleee added this to the Version 4.2.0 milestone Dec 22, 2022
@etimberg etimberg merged commit fd505ac into chartjs:master Dec 22, 2022
@dangreen dangreen deleted the fix-11014 branch January 3, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 4.1.2
Development

Successfully merging this pull request may close these issues.

Colors plugin has incorrect TS type
4 participants
@dangreen @etimberg @kurkle @LeeLenaleee