Use custom scale defaults and dataset axis ID options to determine the axis #11134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etimberg @LeeLenaleee @dangreen @igorlukanin @kurkle I prepared the PR as written in the issue. |
stockiNail
changed the title
etimberg
reviewed
Feb 12, 2023
etimberg
previously approved these changes
Feb 12, 2023
kurkle
previously approved these changes
Feb 12, 2023
etimberg
approved these changes
Feb 13, 2023
kurkle
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10945
This PR is solving the axis option determination if included in the custom scale defaults.
This is also addressing scales configurations (out of the box ones) where the axis is not recognizable by scale ID or axis/position options are missing. It uses datasets x/yAxisID options to determine the axis.