Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooltip.md #11154

Merged
merged 2 commits into from Feb 23, 2023
Merged

Update tooltip.md #11154

merged 2 commits into from Feb 23, 2023

Conversation

olenderhub
Copy link
Contributor

@olenderhub olenderhub commented Feb 20, 2023

Improve textDirection text to: 'rtl' or 'ltr'

LeeLenaleee
LeeLenaleee previously approved these changes Feb 20, 2023
Copy link

@Mholt74 Mholt74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

etimberg
etimberg previously approved these changes Feb 20, 2023
@olenderhub
Copy link
Contributor Author

@Mholt74, what changes do you request? I noticed a tiny issue with the documentation, and that is it :)

I know that I pushed two commits (after pushing first, I noticed that this could be done better, so pushed second)

@LeeLenaleee
Copy link
Collaborator

@olenderhub could you pull the master into your branch so the CI is fixed

Add missing `'`
Improve textDirection text
@olenderhub
Copy link
Contributor Author

@LeeLenaleee I rebased it with master and pushed it by force to my branch. Is it ok? I can also create another PR for it.

@LeeLenaleee
Copy link
Collaborator

No this is fine, CI runs correctly again 👍🏻

@etimberg etimberg merged commit 287394e into chartjs:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants