Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test phase fails when runs against Firefox 110 #11164

Closed
stockiNail opened this issue Feb 26, 2023 · 0 comments · Fixed by #11165
Closed

CI test phase fails when runs against Firefox 110 #11164

stockiNail opened this issue Feb 26, 2023 · 0 comments · Fixed by #11165

Comments

@stockiNail
Copy link
Contributor

Expected behavior

When a PR is submitted, the test cases should end correctly both Chrome and FF.

Current behavior

If you see the history of the CI, you can see that the last one which ended correctly (testing the cases) was using FF 109. Starting using 110, the fixture test cases are failing randomly. And as @dangreen reported, locally it works correctly.

#11121 (comment)

Reproducible sample

https://github.com/chartjs/Chart.js/actions/runs/4255610081/jobs/7403444754

Optional extra steps/info to reproduce

No response

Possible solution

No response

Context

I had a look to new feature of FF 110: https://www.mozilla.org/en-US/firefox/110.0/releasenotes/
I see the following feature which could affect us: GPU-accelerated Canvas2D is enabled by default on macOS and Linux.

having a look to what was done in annotation plugin, we could disable canvas acceleration (not sure if the property is the correct one, :() with the following Karma config:

    customLaunchers: {
      chrome: {
        base: 'Chrome',
        flags: [
          '--disable-accelerated-2d-canvas',
          '--disable-background-timer-throttling',
          '--disable-backgrounding-occluded-windows',
          '--disable-renderer-backgrounding'
        ]
      },
      firefox: {
        base: 'Firefox',
        prefs: {
          'layers.acceleration.disabled': true,
          'gfx.canvas.accelerated': false   // <--- added this one!!! --->
        }
      }
    },

and CI in the plugin should end correctly.

#11121 (comment)

chart.js version

v4.2.1

Browser name and version

FF 110

Link to your project

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant