Disable canvas acceleration in Firefox 110 in test cases #11165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you can see here, the Ci failed when canvas acceleration was enabled. Disabling it, the tests can run against FF 110. |
LeeLenaleee
approved these changes
Feb 26, 2023
kurkle
approved these changes
Feb 26, 2023
SebastiaanSafeguard
added a commit
to SebastiaanSafeguard/chartjs-plugin-zoom
that referenced
this pull request
Mar 2, 2023
kurkle
pushed a commit
to chartjs/chartjs-plugin-zoom
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11164
First commit must fail because the acceleration option is set to true