Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale labels overlapping and cut off #1884

Closed
sLIDe5 opened this issue Jan 11, 2016 · 7 comments
Closed

Scale labels overlapping and cut off #1884

sLIDe5 opened this issue Jan 11, 2016 · 7 comments
Milestone

Comments

@sLIDe5
Copy link

sLIDe5 commented Jan 11, 2016

Problem can be seen here https://jsfiddle.net/63o7793c/2/

Last 2 labels on X axis are overlapping and also on Chrome letter "j" is cut off (this happens also with letter "g"). Meanwhile on Firefox and Edge there are only overlapping labels.

@etimberg
Copy link
Member

Definitely a bug. Probably related to #1731

@etimberg
Copy link
Member

Closing as #1892 was merged

@sLIDe5
Copy link
Author

sLIDe5 commented Jan 12, 2016

This is still not fixed. Commits you referenced fixed #1883 though

@etimberg
Copy link
Member

@sLIDe5 my apologies, I closed the wrong one.

@etimberg etimberg reopened this Jan 12, 2016
@etimberg
Copy link
Member

@sLIDe5 I've looked into this and I have a few questions.

The labels overlap because maxRotation is set to 0, preventing the labels from rotating. The code decides to skip some labels, but also ensures that the first and last label are visible. In this case, which label would you want to see: Jan 4 or Jan 8?

@sLIDe5
Copy link
Author

sLIDe5 commented Jan 18, 2016

@etimberg I suppose it would be better to show Jan 4. Maybe an option not to force first/last label to be shown?

@etimberg
Copy link
Member

Fixed in #2017

Updated fiddle https://jsfiddle.net/dqg4e7ur/1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants