New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dangling label on time scale still :( #2513
Comments
looks like the time scale has another label ..... |
Label :) yes.. Not tooltip hahaha. One of those days |
hmmm, as a debug, what is the max value of the time scale? should be available as |
Looks like it is, in fact, Apr 14th. I'm not sure where it's getting the 15th from! |
that's weird ... I'm guessing when the labels are generated, the ticks array has the 15th in it? |
@tannerlinsley are you still seeing this? |
Yes I am
|
is it possible to post a fiddle? i just recently fixed a case where the 2nd last label could be missed. I'd be interested to see what is happening here (most likely a floating point issue) |
Here's a pen: http://codepen.io/tannerlinsley/pen/akazQN?editors=1010 On Sun, Jul 31, 2016 at 5:44 PM Evert Timberg notifications@github.com
|
@etimberg any ideas? |
Actually, I just realized that this is not technically demonstrating a "dangling label", but it more of an overlapping label issue that should have been fixed in #3064 |
I am seeing a variation of this as well. From the symptoms, it appears that the chart code wants to put a tick out for exactly the final (maximum) data point. That causes overlapping tick labels when that happens to be close to the final calculated tick (based on the time unit setting). When that final data point is not exactly ON the tick boundary, it should be suppressed. Optionally, the next tick should be added to the chart, so that the final data point is inside the range of ticks. I can create a fiddle, if that is not clear. |
Not sure of the cause yet...
The text was updated successfully, but these errors were encountered: