Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangling label on time scale still :( #2513

Closed
tannerlinsley opened this issue May 10, 2016 · 15 comments · Fixed by #4556
Closed

Dangling label on time scale still :( #2513

tannerlinsley opened this issue May 10, 2016 · 15 comments · Fixed by #4556

Comments

@tannerlinsley
Copy link
Contributor

screen shot 2016-05-10 at 6 45 43 pm

Not sure of the cause yet...

@etimberg
Copy link
Member

looks like the time scale has another label .....

@tannerlinsley tannerlinsley changed the title Dangling tooltip on time scale at some widths Dangling label on time scale at some widths May 11, 2016
@tannerlinsley
Copy link
Contributor Author

Label :) yes.. Not tooltip hahaha. One of those days

@etimberg
Copy link
Member

hmmm, as a debug, what is the max value of the time scale? should be available as scale.lastTick

@tannerlinsley
Copy link
Contributor Author

Looks like it is, in fact, Apr 14th. I'm not sure where it's getting the 15th from!

@etimberg
Copy link
Member

that's weird ... I'm guessing when the labels are generated, the ticks array has the 15th in it?

@etimberg
Copy link
Member

@tannerlinsley are you still seeing this?

@tannerlinsley
Copy link
Contributor Author

Yes I am
On Sat, Jul 30, 2016 at 9:17 AM Evert Timberg notifications@github.com
wrote:

@tannerlinsley https://github.com/tannerlinsley are you still seeing
this?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2513 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCZE8Guk51uafle9W9xWc52k7IwC8ks5qa2sUgaJpZM4IbnST
.

@etimberg
Copy link
Member

is it possible to post a fiddle? i just recently fixed a case where the 2nd last label could be missed. I'd be interested to see what is happening here (most likely a floating point issue)

@tannerlinsley
Copy link
Contributor Author

Here's a pen: http://codepen.io/tannerlinsley/pen/akazQN?editors=1010

On Sun, Jul 31, 2016 at 5:44 PM Evert Timberg notifications@github.com
wrote:

is it possible to post a fiddle? i just recently fixed a case where the
2nd last label could be missed. I'd be interested to see what is happening
here (most likely a floating point issue)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2513 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCfMqQbWyowvgjJxa4_IkMwZ8zDYGks5qbTNCgaJpZM4IbnST
.

@tannerlinsley
Copy link
Contributor Author

@etimberg any ideas?

@tannerlinsley
Copy link
Contributor Author

Actually, I just realized that this is not technically demonstrating a "dangling label", but it more of an overlapping label issue that should have been fixed in #3064

@tannerlinsley
Copy link
Contributor Author

Interestingly enough, when I set a legend to be on the right side of the chart, the dangling tick comes back. Very strange..

screen shot 2016-08-05 at 2 47 36 pm

@tannerlinsley
Copy link
Contributor Author

Actually, it's still happening on all of my stuff regardless. I am up to date with the latest version :(

screen shot 2016-08-05 at 3 10 56 pm

@tannerlinsley tannerlinsley changed the title Dangling label on time scale at some widths Dangling label on time scale still :( Aug 5, 2016
@mMerlin
Copy link

mMerlin commented Jun 27, 2017

I am seeing a variation of this as well. From the symptoms, it appears that the chart code wants to put a tick out for exactly the final (maximum) data point. That causes overlapping tick labels when that happens to be close to the final calculated tick (based on the time unit setting). When that final data point is not exactly ON the tick boundary, it should be suppressed. Optionally, the next tick should be added to the chart, so that the final data point is inside the range of ticks.

I can create a fiddle, if that is not clear.

@simonbrunel
Copy link
Member

Fixed by #4556 (CodePen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants