Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible memory leak #4291

Closed
GabrielMancik opened this issue May 26, 2017 · 4 comments
Closed

Possible memory leak #4291

GabrielMancik opened this issue May 26, 2017 · 4 comments
Assignees
Milestone

Comments

@GabrielMancik
Copy link
Contributor

I have a simple bar chart with one dataset. At this time chart.config.data.datasets[0]._meta contains only one property. When I destroy chart and create new one i would expect that chart.config.data.datasets[0]._meta will still contain only one property but different than before. This is not true. Each time i destroy and recreate chart new property is appended to meta object.

fiddle example: https://jsfiddle.net/Luaf2tm4/298/

@GabrielMancik
Copy link
Contributor Author

Why do chart.config.data.datasets[0]._meta even has to be object (dictionary)? Is multiple properties logically valid state?

@simonbrunel
Copy link
Member

The _meta object contains internal data, keyed by the chart id since the user data can be shared by multiple chart instances. However you right, we don't clean this object when destroying a chart (I think there is already a related issue).

@simonbrunel simonbrunel added this to the Version 2.7 milestone May 26, 2017
@benmccann
Copy link
Contributor

I think this might be fixed by #4586 ?

@simonbrunel
Copy link
Member

simonbrunel commented Aug 2, 2017

Fixed by #4586 (http://jsfiddle.net/Luaf2tm4/563/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants