Fix for issue #4294 #4295
Merged
Fix for issue #4294 #4295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
approved these changes
May 27, 2017
simonbrunel
reviewed
May 27, 2017
| var dataMin = Number.MAX_SAFE_INTEGER; | ||
| var dataMax = Number.MIN_SAFE_INTEGER; | ||
| // Integer constants are from the ES6 spec. | ||
| var dataMin = Number.MAX_SAFE_INTEGER || 9007199254740991; |
There was a problem hiding this comment.
Is there any advantage to keep the constants here compared to simply hard code these values?
There was a problem hiding this comment.
Only that it seems more future proof. It looks like Edge supports these, so in 'the future' the constants should be used everywhere and the hard coded values will never come into play. I've no strong opinion on this so let me know if you'd like it changed.
simonbrunel
approved these changes
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hard coded integer constants for *_SAFE_INTEGER which are not available on IE
Fixes #4294