Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scatter chart default to hide lines #4381

Merged
merged 1 commit into from Jun 25, 2017
Merged

Update scatter chart default to hide lines #4381

merged 1 commit into from Jun 25, 2017

Conversation

etimberg
Copy link
Member

Resolves #4372

Note: This is a potentially breaking change if we think that scatter defaults should show lines. In which case, I will update the two sample files

@simonbrunel
Copy link
Member

Seems like a breaking change if we change defaults?. About the scatter chart definition, I really don't know what it should look like.

@etimberg
Copy link
Member Author

Right. In that case, I can just change the samples and we can change the defaults for v3.

@simonbrunel
Copy link
Member

When searching scatter chart over the web, all results look like multiple points/symbols without lines (so the expected behavior described in #4372). So may be better to change the default in 2.7 and justify the breaking change as a bug fix?

@brylie @kumarharsh thought?

@kumarharsh
Copy link

Personally, I've never seen a scatter chart with lines - yes, it is based off the line chart, but i think that's where the similarities end.

There is another change which needs to be done, which was not clear to me at the start - both the axes need to have numeric scales by default in the scatter chart, which the line chart doesn't have by default.

@simonbrunel
Copy link
Member

I vote for the breaking change then, and change defaults :) @etimberg what do you think?

@etimberg
Copy link
Member Author

I'm fine with changing the defaults. Will update this PR accordingly

@etimberg etimberg merged commit 7fa6052 into master Jun 25, 2017
@etimberg etimberg deleted the fix/4372 branch June 25, 2017 12:48
@openjck
Copy link

openjck commented Sep 19, 2017

If anyone else comes across this issue looking for how to restore lines for scatter charts in chart.js, just add showLines: true to the configuration object.

carandraug added a commit to MicronOxford/SpekCheck that referenced this pull request Feb 8, 2018
Chart.js 2.7.0 introduced a backwards incompatible change, scatter plots
do not show lines by default anymore.  See their bug chartjs/Chart.js#4381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants